Page Index Toggle Pages: 1 Send TopicPrint
Normal Topic Untranslatable text (Read 4277 times)
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Untranslatable text
Reply #7 - Sep 22nd, 2014 at 2:58pm
Print Post  
Dandello wrote on Sep 22nd, 2014 at 1:23pm:
When is a bug not a bug? - when it's in a bit of code that never gets called.  Wink


Bug is just an undocumented feature. It is secondary if the feature works or not.
  
Back to top
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Untranslatable text
Reply #6 - Sep 22nd, 2014 at 1:23pm
Print Post  
Monni wrote on Sep 22nd, 2014 at 3:53am:
lol... so you're saying the bug is that it's not called anywhere instead of it containing untranslatable text...  Tongue


When is a bug not a bug? - when it's in a bit of code that never gets called.  Wink
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Untranslatable text
Reply #5 - Sep 22nd, 2014 at 10:09am
Print Post  
Ok... I deleted them in my copy... makes the file a little smaller Wink
  
Back to top
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Untranslatable text
Reply #4 - Sep 22nd, 2014 at 4:39am
Print Post  
Yeah, it seems to have been added for 3.0. Need to test and see what it was supposed to do. Otherwise it should probably come out of ajax.js.
Edited:
The javascript that call was embedded in in 3.0 doesn't appear to work. It doesn't throw a javascript error - it just doesn't seem to do anything - and it didn't bring up a popup with the rotating gif. I suspect that code was never finished. So those 2 functions are coming out of ajax.js as unnecessary.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Untranslatable text
Reply #3 - Sep 22nd, 2014 at 3:53am
Print Post  
Dandello wrote on Sep 21st, 2014 at 11:48pm:
Okay - this one's interesting. I don't see that that function is actually called anywhere.  Huh


lol... so you're saying the bug is that it's not called anywhere instead of it containing untranslatable text...  Tongue

I could find only one place where it was used, but I really had to go back a long time in svn tree... Sources/MyCenter.pl

Maybe the whole function can be deleted?
  
Back to top
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Untranslatable text
Reply #2 - Sep 21st, 2014 at 11:48pm
Print Post  
Okay - this one's interesting. I don't see that that function is actually called anywhere.  Huh
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Untranslatable text
Reply #1 - Sep 21st, 2014 at 10:28pm
Print Post  
Let me see what I can do.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Untranslatable text
Sep 21st, 2014 at 9:30pm
Print Post  
In yabbfiles/ajax.js, texts "Sending PM" and "Complete" are hard-coded.
  
Back to top
IP Logged
 
Page Index Toggle Pages: 1
Send TopicPrint