Page Index Toggle Pages: 1 Send TopicPrint
Normal Topic Where we are on 2.7.0 (Read 434 times)
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Where we are on 2.7.0
Oct 14th, 2016 at 2:46pm
Print Post  
I was hoping to have a strict alpha posted to the SourceForge SVN today (Oct 14th, 2016 at 2:26pm) but I swear every time I test a section I don't normally use something glitches up. 

The problem is: YaBB's base code is old. It's the poster child for legacy code.

YaBB was written before Perl really got security aware and before most of the ideas concerning localizing variables and testing for whether or not variables have explicitly established values got a foothold (or were even invented in some cases). All of YaBB's variables were originally what is now called 'global' -  a global variable is (for the most part) inherited by whatever function calls that variable, no matter where that function is called or resides.

The strict pragma requires that all variables be declared as either 'my' or 'our'. And sometimes it's hard to tell if a variable should be an 'our' or a 'my'. (There's also a 'local' but that's not good according to Damien Conway.) And then there's the variables that, even though they've been declared to be 'our', don't want to be exported from where they are.  Smiley

And then there's the overly complicated functions (sub routines). Research has been done that indicates a sub routine should not be overly complicated (having too many if/else statements and internal code blocks) - an overly complicated routine is not easily testable AND easily broken and may actually take longer to process than simpler code using easily testable chunks or sub routines. (The display sub routine comes in at a whopping complexity score of 510. 20 is considered 'good'.)
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Where we are on 2.7.0
Reply #1 - Jan 30th, 2017 at 11:55pm
Print Post  
Well, we're still at the phase of everytime I test a function I don't normally use, I find a glitch - today it was 'away' - that one where if it's set it sends 1 email that the person is away... Only there is actually bug in it that dates back to at least 2.5AE where it wasn't counted as a PM and so created -1 new PMs when read.  Smiley

And MailMembers works - but never sent back the proper sort and reverse info.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Where we are on 2.7.0
Reply #2 - Aug 30th, 2017 at 12:58pm
Print Post  
We are still testing 2.7. Now we're into the conversion utilities using data from some 'big' boards that have also been upgraded many times. (Amazing what glitches slip in over time when there are thousands of members and hundreds of thousand posts.)

New changes to 2.7 - checking that board names are unique when tested lowercase. Having board names that rely on case sensitivity can cause data loss when the forum is moved to a case insensitive OS (like most Windows installs).
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Page Index Toggle Pages: 1
Send TopicPrint