(UTC)
  YaBB 2.6 Forum › Bug Zone › YaBB Bugs › Perl
‹ Previous Topic | Next Topic ›
Page Index Toggle Pages: 1 [2]  Send TopicPrint
Hot Topic (More than 10 Replies) Perl (Read 18745 times)
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Perl
Reply #9 - May 21st, 2016 at 4:52pm
Print Post  
Ack!! Some warnings/errors go the the Apache error log and the ones you least expect (Like Captcha problems) go into the YaBB error log. But I found the *tard.  Smiley

Edited:
The problems I'm seeing in 2.6.12 has to do with uninitialized variables in equivalency or numeric context, used once variables (because they're being imported) and the worst ones, non-numeric strings and blanks put into a numeric context. Most of the ones in the if statements can be fixed by first checking that the variable exists and isn't undef. A couple places the variable has to be checked to make sure it's a number instead of a text string. I mean, seriously, '1u'  being compared to a number? How did that EVER work? (You don't have to answer that - I suspect older versions of Perl simply defaulted it to 0 when it saw a WTF.
  
Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Perl
Reply #8 - May 21st, 2016 at 4:25pm
Print Post  
I used a lot of croaks with variable contents to track which path was taken when diagnosing why things didn't work after the Perl upgrade... It took me half dozen attempts for it to hit even the first croak Wink
Essentially I had to reverse and negate almost all of the if tests.
  
Back to top
GTalkSkype/VoIPFacebookTwitterYouTubeICQYIM  
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Perl
Reply #7 - May 21st, 2016 at 2:26pm
Print Post  
Another interesting one: when using the -w flag in YaBB.pl, Captcha doesn't render - not even in the Admin Center. But it does when there's no -w flag and I use 'use warnings;' in YaBB.pl instead.  Smiley

The problem appears to be related to Captcha.pm not rendering properly under 'use warnings'. Decoder.pm also has a problem when called from the registration page when Captcha is enabled. (Working on that one.)
Edited:
Captcha.pm only works with 'no warnings;' when YaBB.pl has the -w flag. Hunting down the cause.
« Last Edit: May 21st, 2016 at 3:53pm by Dandello »  
Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Perl
Reply #6 - May 16th, 2016 at 7:56am
Print Post  
Dandello wrote on May 16th, 2016 at 1:41am:

Code (Perl)
Select All
$CGI_query->param
without the () gets the whole parameter list in CGI 4.28. And apparently the new system requires a stated parameter if the () is used.


Apache error log already looks a lot better... only 4 errors in 11 hours and all of them are harmless.
  
Back to top
GTalkSkype/VoIPFacebookTwitterYouTubeICQYIM  
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Perl
Reply #5 - May 16th, 2016 at 1:41am
Print Post  
It was introduced in CGI 4.28 (approx) and it does (apparently) work with older versions of Perl. BUT there are other code differences.
Code (Perl)
Select All
            for my $name ( $CGI_query->param ) {
                if ( $name =~ /^file(\d+|_avatar)$/xsm ) { next; }

        # files are directly called in Profile.pm, Post.pm and ModifyMessages.pl
                @value = $CGI_query->multi_param($name);


Code (Perl)
Select All
$CGI_query->param
without the () gets the whole parameter list in CGI 4.28. And apparently the new system requires a stated parameter if the () is used.
  
Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Perl
Reply #4 - May 15th, 2016 at 11:00pm
Print Post  
Dandello wrote on May 15th, 2016 at 10:34pm:
You're right. Later I'll test how that code behaves on older versions of Perl.


I haven't checked when multi_param() was introduced but you might want to use version check if it was introduced too late...
  
Back to top
GTalkSkype/VoIPFacebookTwitterYouTubeICQYIM  
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Perl
Reply #3 - May 15th, 2016 at 10:34pm
Print Post  
You're right. Later I'll test how that code behaves on older versions of Perl.
Edited:
multi_param does NOT work with Perl 5.08 or Perl 5.14. (At least with how they're configured here but I'm updating the CGI module to see it that helps.)


Edited:
Nope - even with the newest version of the CGI module the call for multi-param crashes YaBB.
What we're going to have to do is write a mod specifically for upgrading to use Perl 2.22. (Like the Apache 2.4 mod.)
  
Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Perl
Reply #2 - May 15th, 2016 at 9:41pm
Print Post  
The line:

Quote:

@value = $CGI_query->param($name);


needs to be:

Quote:

@value = $CGI_query->multi_param($name);


When using Perl 5.22. At least Perl 5.20 still had param() working in list context.
  
Back to top
GTalkSkype/VoIPFacebookTwitterYouTubeICQYIM  
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Perl
Reply #1 - May 15th, 2016 at 9:36pm
Print Post  
in Subs.pm find
Code (Perl)
Select All
    {yabbbr}
and replace with
Code (Perl)
Select All
    \{yabbbr}


also in Subs.pm find
Code (Perl)
Select All
            foreach my $name ( $CGI_query->param() ) {

and replace with
Code (Perl)
Select All
            my @nama = $CGI_query->param();
             foreach my $name (@nama) {


Now I have NOT fully tested this but it doesn't throw errors to the Apache errorlog and my YaBB install appears to still be working.

Edited:
There are similar issues to the yabbbr in ExtendedProfiles.pm  Embarrassed
  
Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Perl
May 15th, 2016 at 8:51pm
Print Post  
Apache error log is full of:
Quote:

Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/ { <-- HERE yabbbr} / at ./Sources/Subs.pm line 1861.


Quote:

Subs.pm: CGI::param called in list context from ./Sources/Subs.pm line 1142, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/local/cpanel/3rdparty/perl/522/lib64/perl5/cpanel_lib/CGI.pm line 404.
  
Back to top
GTalkSkype/VoIPFacebookTwitterYouTubeICQYIM  
IP Logged
 
Page Index Toggle Pages: 1 [2] 
Send TopicPrint
‹ Previous Topic | Next Topic ›
 
  « Board Index ‹ Board Top  

YaBB 2.6 Forum » Powered by YaBB 2.6.12!
YaBB Forum Software © 2000-2024. All Rights Reserved.

Valid RSS Valid XHTML Valid CSS Powered by Perl Source Forge