Page Index Toggle Pages: [1] 2  Send TopicPrint
Hot Topic (More than 10 Replies) Some general rules of thumb for Modders (Read 8243 times)
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Some general rules of thumb for Modders
Reply #16 - Jul 23rd, 2014 at 9:35pm
Print Post  
Dandello wrote on Jul 23rd, 2014 at 8:50pm:
But I do need to look for the remaining 2.5 remnants.)


I could count about 10 files that still mention 2.5, but should maybe mention 2.6 instead... I guess those files were unchanged from 2.5 Wink
For others, the mentioning of 2.5 is intentional.
  
Back to top
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Some general rules of thumb for Modders
Reply #15 - Jul 23rd, 2014 at 8:50pm
Print Post  
I think this should go on the list of ideas for 2.6.2. (For that matter, having a whole column of 'YaBB 2.6.0' doesn't bother me.   Grin  But I do need to look for the remaining 2.5 remnants.)

2.5.2 was based on 2.5AE. 2.6.0 went back, in some cases, to the original 2.4 mods that Next added, but it's based mostly on 2.5.2. ( Next was a dead end - too much was left half finished.)
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Some general rules of thumb for Modders
Reply #14 - Jul 23rd, 2014 at 8:37pm
Print Post  
Dandello wrote on Jul 23rd, 2014 at 8:33pm:
I see what you mean ... if the Version is the 'current' one (the one in Languages//version.txt), then leave it out in the Detailed Version list.


Exactly... But only if there is revision information... or some other data besides the plain version number... Otherwise you will end up with empty version string Wink
  
Back to top
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Some general rules of thumb for Modders
Reply #13 - Jul 23rd, 2014 at 8:33pm
Print Post  
I see what you mean ... if the Version is the 'current' one (the one in Languages//version.txt), then leave ou the string in the Detailed Version list.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Some general rules of thumb for Modders
Reply #12 - Jul 23rd, 2014 at 8:19pm
Print Post  
Dandello wrote on Jul 23rd, 2014 at 8:00pm:
Code (Perl)
Select All
            ${$txtrevision} =~ s/$Revision: (.*?) $/Build $1/igsm; 



The rest of the version sting gets put in as is.  Wink So if $Revision is left out it doesn't matter.


I mean... It's pretty redundant to have the YaBB version at start of every file version string... It should be stripped if it exists... I still see files where the version part is 2.5.x which will confuse users, because they think the file needs an update even though same file works for 2.5 and 2.6 series (both are actually versions of YaBB Next Edition).
  
Back to top
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Some general rules of thumb for Modders
Reply #11 - Jul 23rd, 2014 at 8:00pm
Print Post  
Code (Perl)
Select All
            ${$txtrevision} =~ s/\$Revision\: (.*?) \$/Build $1/igsm; 



The rest of the version sting gets put in as is.  Wink So if $Revision is left out it doesn't matter.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Some general rules of thumb for Modders
Reply #10 - Jul 23rd, 2014 at 7:49pm
Print Post  
Dandello wrote on Jul 23rd, 2014 at 7:19pm:
Some Modders see how the YaBB file tops are put together and assume that's the only way to do it, including adding the YaBB SVN build number which doesn't apply to the mod.

YaBB internally replaces
Code
Select All
$Revision: $ 

with 'Build' in the Detailed Version list.
So having a revision number of some nature helps keep track of what's been installed - no matter how it's written.


Just my five cents about the automatic parsing of "$Revision: ...$" ... I was just suggesting that logic could be extended for files that obviously can't have SVN revision information... 
Instead of blindly looking for $Revision in the string, it should strip the start of the string "YaBB [\d]\.[\d]\.[\d] " and then parse "\$Revision (.*?) \$" only if it exists and if it doesn't exist, copy the information verbatim.
  
Back to top
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Some general rules of thumb for Modders
Reply #9 - Jul 23rd, 2014 at 7:19pm
Print Post  
Some Modders see how the YaBB file tops are put together and assume that's the only way to do it, including adding the YaBB SVN build number which doesn't apply to the mod.

YaBB internally replaces
Code
Select All
$Revision: $ 

with 'Build' in the Detailed Version list.
So having a revision number of some nature helps keep track of what's been installed - no matter how it's written.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Some general rules of thumb for Modders
Reply #8 - Jul 23rd, 2014 at 7:03pm
Print Post  
Dandello wrote on Jul 23rd, 2014 at 6:56pm:
More general ideas -
But first an explanation of SVN Build numbers.
The Build numbers you see for YaBB are assigned by the Subversion program that keeps track of changes. The number you see reflects the number of 'commits' (changed files that were uploaded - either individually or as a group) 

Mods don't get added to YaBB Subversion. So logically, files that go with Mods can (and probably should) use a different numbering system. (Like simply starting with 1 as in
Code (Perl)
Select All
$donationpagepmver = 'YaBB 2.6.0 $Revision: 1 $'; 

Which would mean that this version of the mod was written for 2.6.0 and this is the first iteration of this file.

Also remember - you can, and should, add your own name to the copyright statement as the mod writer. (Just remember to give credit to previous writers if there were any.)

And yes, I have to go back and fix my own mods to get therm current.  Wink


IMHO, the "$Revision: 1 $" part should be totally removed unless the mod code is hosted on SVN server... It's up to mod developer if she/he wants to have version numbering instead for the mod.
  
Back to top
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Some general rules of thumb for Modders
Reply #7 - Jul 23rd, 2014 at 6:56pm
Print Post  
More general ideas -
But first an explanation of SVN Build numbers.
The Build numbers you see for YaBB are assigned by the Subversion program that keeps track of changes. The number you see reflects the number of 'commits' (changed files that were uploaded - either individually or as a group) 

Mods don't get added to YaBB Subversion. So logically, files that go with Mods can (and probably should) use a different numbering system. (Like simply starting with 1 as in
Code (Perl)
Select All
$donationpagepmver = 'YaBB 2.6.0 $Revision: 1 $'; 

Which would mean that this version of the mod was written for 2.6.0 and this is the first iteration of this file.

Also remember - you can, and should, add your own name to the copyright statement as the mod writer. (Just remember to give credit to previous writers if there were any.)

And yes, I have to go back and fix my own mods to get therm current.  Wink
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Some general rules of thumb for Modders
Reply #6 - Jul 18th, 2014 at 5:42pm
Print Post  
Thank you.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
pyragony54
God Member
*****
Offline


I Love YaBB!

Posts: 664
Location: Йошкар-Ола
Joined: May 25th, 2014
Gender: Male
Re: Some general rules of thumb for Modders
Reply #5 - Jul 18th, 2014 at 5:35pm
Print Post  
If everything is still. Incidentally, I have posted all your mods under your name.
  

Bad manners keep people but the only reason for a kind of privilege, because no skin them on the mouth.
Back to top
 
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Some general rules of thumb for Modders
Reply #4 - Jul 18th, 2014 at 5:15pm
Print Post  
pyragony54 wrote on Jul 18th, 2014 at 4:22pm:
For the necessary advertising I worry already.


We're not in competition for limited dollars - we just want YaBB to succeed and have happy users. (So remember to put a link to your site in your signature.  Wink )
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
pyragony54
God Member
*****
Offline


I Love YaBB!

Posts: 664
Location: Йошкар-Ола
Joined: May 25th, 2014
Gender: Male
Re: Some general rules of thumb for Modders
Reply #3 - Jul 18th, 2014 at 4:22pm
Print Post  
Okay, accepted. But do not deceive yourself because sometimes that is not even English speaking will download for me. For the necessary advertising I worry already. I have the page already logged in GoogleDashboard.
  

Bad manners keep people but the only reason for a kind of privilege, because no skin them on the mouth.
Back to top
 
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Some general rules of thumb for Modders
Reply #2 - Jul 18th, 2014 at 3:57pm
Print Post  
I expect that people downloading from your site will be expecting the German and German Du parts to be included.  Wink  (After all, you're catering to German speakers, right?  Grin)

I'm not repacking the older zips here until I have the download Mods section done. 
Let's just call the additional languages parts a suggestion for the future.  Wink

  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Page Index Toggle Pages: [1] 2 
Send TopicPrint