Page Index Toggle Pages: 1 Send TopicPrint
Hot Topic (More than 10 Replies) Suggestion about profile links (Read 24137 times)
Cecily
Guest


Re: Suggestion about profile links
Reply #14 - Oct 17th, 2014 at 4:03pm
Print Post  
Guest test
  
Back to top
 
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Suggestion about profile links
Reply #13 - Oct 7th, 2014 at 3:03pm
Print Post  
The new sub for calling viewprofile is in testing here. (Admin choice of redirect to new screen or disable link and use 'title' instead.)  I THINK I caught all the viewprofile links that weren't already handled via the QuickLinks guest catching routine.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Suggestion about profile links
Reply #12 - Oct 6th, 2014 at 4:30pm
Print Post  
Oh, if it used a single function or sub call that would be too easy.  Tongue

For this I started looking through all the files for 'action=viewprofile' and kept my fingers crossed that the related code wasn't so convoluted I got a headache looking at it.

I'll get back to this later today or tomorrow. Got Real World things to do today.

Oooh... A new sub  Grin.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Suggestion about profile links
Reply #11 - Oct 6th, 2014 at 3:17pm
Print Post  
Dandello wrote on Oct 6th, 2014 at 2:37pm:
This is just a first iteration for testing. I'll be going back and reediting things once I've gotten some 'admin choices' figured out. (And there maybe one live link still hiding somewhere - It's showing in the errorlog but it could also be a link generated by a bot trying to get in.)


I usually convert them as functions and then use "grep" to find where the unique part of the link is used raw on the sources... when it uses a function, it should only show one result Wink
  
Back to top
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Suggestion about profile links
Reply #10 - Oct 6th, 2014 at 2:37pm
Print Post  
This is just a first iteration for testing. I'll be going back and reediting things once I've gotten some 'admin choices' figured out. (And there maybe one live link still hiding somewhere - It's showing in the errorlog but it could also be a link generated by a bot trying to get in.)
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Suggestion about profile links
Reply #9 - Oct 6th, 2014 at 10:08am
Print Post  
Dandello wrote on Oct 6th, 2014 at 4:52am:
Current tests - using the title tag to create 'non-error popups' explaining to guests that access to member profiles is for memebr profiles. - Not admin editable yet or admin choice as to having a 'redirect' to registration page.


Instead of using two spans, you should combine the parameters to one span...
  
Back to top
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Suggestion about profile links
Reply #8 - Oct 6th, 2014 at 4:52am
Print Post  
Current tests - using the title tag to create 'non-error popups' explaining to guests that access to member profiles is for memebr profiles. - Not admin editable yet or admin choice as to having a 'redirect' to registration page.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Suggestion about profile links
Reply #7 - Sep 17th, 2014 at 8:35pm
Print Post  
Off to look for more of them.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Suggestion about profile links
Reply #6 - Sep 17th, 2014 at 7:51pm
Print Post  
When not logged in, link to profile of last person who edited a poll is still visible.
  
Back to top
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Suggestion about profile links
Reply #5 - Sep 17th, 2014 at 10:16am
Print Post  
I will test how much shorter the error log gets Wink
  
Back to top
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Suggestion about profile links
Reply #4 - Sep 17th, 2014 at 2:42am
Print Post  
Uploaded here (and in the SVN) changes to BoardIndex.pm, MessageIndex.pm and Load.pm to disable links to the Profile Page when it's a guest viewing.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Suggestion about profile links
Reply #3 - Sep 16th, 2014 at 8:59pm
Print Post  
My delay was that I already had 20 script pages open for editing and about 5 browser windows.   Wink (And lunch, and...)
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Suggestion about profile links
Reply #2 - Sep 16th, 2014 at 8:02pm
Print Post  
With quick test by logging out, the main problem was where it shows last poster of each board, or starter and last poster of each thread... Clicking the name of the user will give 403 as expected, but it should not be a link at all to avoid the extra page load for crawlers and other guests.
  
Back to top
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Suggestion about profile links
Reply #1 - Sep 16th, 2014 at 7:29pm
Print Post  
Good idea - I'll double check that all the profile links are, in fact, disabled when they're supposed to be.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Suggestion about profile links
Sep 16th, 2014 at 3:39pm
Print Post  
If admin has disabled access to user profiles, links to them should be hidden for guests... This eases the server load a lot as crawlers won't try to load pages that they have no rights to view. This is especially problematic as the URL for the profile changes every time and crawlers can't cache the server result.
  
Back to top
IP Logged
 
Page Index Toggle Pages: 1
Send TopicPrint