Page Index Toggle Pages: [1] 2  Send TopicPrint
Hot Topic (More than 10 Replies) Looking toward 2.6.1 (Read 29656 times)
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Looking toward 2.6.1
Reply #17 - Aug 25th, 2014 at 8:15pm
Print Post  
Off-Topic replies have been moved to this Topic.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Looking toward 2.6.1
Reply #16 - Aug 24th, 2014 at 7:18pm
Print Post  
You're absolutely right, we are running development of  2.6.0/2.6.1 and 2.6.2 in parallel. And now's the time to get the code to good standards (not to mention right).

The things that appear like they'll take quite a bit of time to implement (like the Admin Center and fixing the template editor) will get pushed to 2.6.2. And as much as I would like to freeze 2.6.1, everytime I edit a mod I see places where there are long if/elsif chains and multitudes of variables that would be better in an array or a hash. - Next up, MemberGroups.  Grin
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
XTC
Global Moderator
*****
Offline


YaBB 2.6.0/1/11 Mods

Posts: 159
Location: @ustria
Joined: Feb 12th, 2014
Gender: Male
Re: Looking toward 2.6.1
Reply #15 - Aug 24th, 2014 at 7:17pm
Print Post  
Hi


Now it looks ok for me  Cool .... only one problem (xonderproblem  Tongue Lips Sealed ) with Slimbrowser!

The  "No Parse" Button is not in the first row  Sad


.... in Crome it looks right.

lg XTC

  

Back to top
 
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Looking toward 2.6.1
Reply #14 - Aug 24th, 2014 at 7:03pm
Print Post  
We're already doing 2.6.1 and 2.6.2 in parallel... Basically choosing one or the other... As there is no code freeze for 2.6.1 yet, I will just post everything I notice and you can choose if it is .1 or .2 (or later)...
  
Back to top
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Looking toward 2.6.1
Reply #13 - Aug 24th, 2014 at 6:57pm
Print Post  
Adding the $ubbcbak to PostBox.pm. And I suspect the problem with how the css buttons look in the alternate template is that this:
Code (CSS)
Select All
.ubbcbutton {
    height: 22px;
    width: 23px;
    border: 0;
    margin: 0 -2px;
    background-position: top right;
    background-repeat: no-repeat;
    text-decoration: none;
    font-size: 18px;
    vertical-align: top;
    display: inline-block;
} 

is missing from the xonder_gold.css file.

I'm in the process of going through all the || as I find them as even I've noticed places where they're just plain wrong.  (The vast majority of these are from old code and any newer ones are due to copying what the previous coders did.)

The fixing hard template coding in the Admin Center is set for 2.6.2 or beyond. YaBB has always assumed there should only be one pretty much non-editable admin template. As for other template support, it's always been a pain and the WYSIWYG template editor has never worked quite right.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Looking toward 2.6.1
Reply #12 - Aug 24th, 2014 at 5:48pm
Print Post  
Code
Select All
$ubbcbak = 'ubbc2.png';
 


is missing from top of PostBox.pm
  
Back to top
IP Logged
 
XTC
Global Moderator
*****
Offline


YaBB 2.6.0/1/11 Mods

Posts: 159
Location: @ustria
Joined: Feb 12th, 2014
Gender: Male
Re: Looking toward 2.6.1
Reply #11 - Aug 24th, 2014 at 5:26pm
Print Post  
Hello

Dandello wrote on Aug 22nd, 2014 at 2:11pm:
More additional support for Mods has been added.
The UBBC buttons are now formatted by CSS in much the same way as the regular buttons are - background and foreground images so the background can be changed.

For me the css buttons do not work right or can make problems  Undecided

In IM it shows me without border ...



In Thread Posting with ....



On my Board with "xonder_gold" Template it look like this one  Lips Sealed



lg XTC
  

Back to top
 
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Looking toward 2.6.1
Reply #10 - Aug 24th, 2014 at 4:59pm
Print Post  
Dandello wrote on Aug 24th, 2014 at 3:22pm:
Trunk or 2.6 branch?


I'm looking at trunk currently... 

I was looking lines surrounding changes and as far as I understand, there is still || operator used in places where there is absolutely no chance in even a billion that it should be there... I can't make a diff without including same mistake in about 80-90% of the source files...

The simple issue is that || operator should not be used for string literals or variables that might hold a string... It only works for comparing if some variable is numeric zero or binary false. As the usual fix is to use either // operator or //=, the fix for old Perl version is pretty ugly.

The bigger issue is that same variable should be defined in only one source file if the content is static and equal in all files. Also, there seems to be missing 99% of the code for implementing template support in Admin Center... It's all hard-coded literal strings assuming default template is always the current template.
  
Back to top
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Looking toward 2.6.1
Reply #9 - Aug 24th, 2014 at 3:22pm
Print Post  
Trunk or 2.6 branch?
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Looking toward 2.6.1
Reply #8 - Aug 24th, 2014 at 3:20pm
Print Post  
Dandello wrote on Aug 24th, 2014 at 12:44pm:
Okay. Although the snapshot zip is okay, the actual checkout may not be. That's just bonkers.

Just checked what's in SourceForge - there doesn't seem to be anything wierd when looking at the file structure and files they list. I did an update to from the SVN to my folder and everything looks okay.


I don't know where the shit did hit the fan there... 
But... looking at rev 1550 it looks just plain short-circuit code...
  
Back to top
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Looking toward 2.6.1
Reply #7 - Aug 24th, 2014 at 12:44pm
Print Post  
Okay. Although the snapshot zip is okay, the actual checkout may not be. That's just bonkers.

Just checked what's in SourceForge - there doesn't seem to be anything wierd when looking at the file structure and files they list. I did an update to from the SVN to my folder and everything looks okay.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Looking toward 2.6.1
Reply #6 - Aug 24th, 2014 at 9:04am
Print Post  
When I tried checkout, I got mostly normal files, but some files were in directory with no name, and all of those were causing hiccups. 
Seems hell breaks loose if same commit has both adds and deletes... It just ignores all the svn properties for added files. Somehow it combines random add+delete pair as single copy even if file names don't match.
  
Back to top
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Looking toward 2.6.1
Reply #5 - Aug 23rd, 2014 at 8:27pm
Print Post  
I downloaded the snapshops for 1545 and 1547 and compared them to what I have in the 'commit' folder and they match up 100% (except for some missing files that when in on commit 1546). They also created good installs. Could be SourceForge is having issues.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Monni
Senior Member
****
Offline


Min izāmō

Posts: 413
Location: Kaarina, Finland
Joined: Jul 16th, 2014
Gender: Male
Re: Looking toward 2.6.1
Reply #4 - Aug 23rd, 2014 at 5:57pm
Print Post  
Dandello wrote on Aug 22nd, 2014 at 8:29pm:
That's weird. The new png files were created using an older version of Photoshop and uploaded to the SVN using TortoiseSVN. (I assume it's the new graphics that aren't registering as binary.) Those graphics are the one's I've uploaded here.


Might be a bug in the SVN post-commit script or even the SVN browser itself... But I can't diagnose it... It just did throw up the checkout here...
  
Back to top
IP Logged
 
Dandello
Forum Administrator
*****
Offline


I love YaBB 2.7!

Posts: 1759
Location: The Land of YaBB
Joined: Feb 12th, 2014
Gender: Female
Re: Looking toward 2.6.1
Reply #3 - Aug 22nd, 2014 at 8:29pm
Print Post  
That's weird. The new png files were created using an older version of Photoshop and uploaded to the SVN using TortoiseSVN. (I assume it's the new graphics that aren't registering as binary.) Those graphics are the one's I've uploaded here.
  

Perfection is not possible. Excellence, however, is excellent.
Back to top
WWW  
IP Logged
 
Page Index Toggle Pages: [1] 2 
Send TopicPrint